Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump node-disk-manager to 0.7.2 #272

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Bump node-disk-manager to 0.7.2 #272

merged 1 commit into from
Aug 23, 2024

Conversation

brandboat
Copy link

@brandboat brandboat commented Aug 23, 2024 •
edited
Loading

Bump NDM again as action failed and no 0.7.1 publish in gh-page, https://github.com/harvester/charts/actions/runs/10503401996, hope this time it will pass...

Looking up latest tag...
Discovering changed charts since 'harvester-load-balancer-0.4.0'...
Installing chart-releaser...
Adding cr directory to PATH...
Packaging chart 'charts/harvester-node-manager'...
Successfully packaged chart in /home/runner/work/charts/charts/charts/harvester-node-manager and saved it to: .cr-release-packages/harvester-node-manager-0.3.0.tgz
Releasing charts...
Error: error creating GitHub release harvester-node-manager-0.3.0: POST https://api.github.com/repos/harvester/charts/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

The root cause was I changed node-manager image tag in c8cf429 without the version change which let https://github.com/harvester/charts/actions/runs/10503401996 failed to publish a new release and new tag.

Error: error creating GitHub release harvester-node-manager-0.3.0: POST https://api.github.com/repos/harvester/charts/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

And in https://github.com/helm/chart-releaser-action/blob/d1e09fd16821c091b45aa754f65bae4dd675d425/cr.sh#L297 it use latest tag compared to the latest commit in pr to determine which chart need a new release. Unfortunately, the tag harvester-node-manager-0.3.0 didn't include the chage c8cf429. So if we checkout to d468e7c (the harvester-node-manager-0.7.1 commit) and run

git diff --find-renames --name-only harvester-node-manager-0.3.0  -- charts

we'll see output

charts/harvester-load-balancer/Chart.yaml
charts/harvester-load-balancer/values.yaml
charts/harvester-node-disk-manager/Chart.yaml
charts/harvester-node-disk-manager/templates/crds/harvesterhci.io_blockdevices.yaml
charts/harvester-node-manager/values.yaml

It includes several changes not related to node-disk-manager... and as those charts versions (node-manager-0.3.0) are already exists in github tags, the release action raise error.

@Vicente-Cheng Vicente-Cheng merged commit 82bf683 into harvester:release Aug 23, 2024
3 checks passed
@brandboat brandboat deleted the bump-ndm-again branch August 23, 2024 05:33
@brandboat brandboat mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vicente-Cheng Vicente-Cheng Vicente-Cheng approved these changes

@bk201 bk201 bk201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandboat @Vicente-Cheng @bk201